[energidataservice] Increase robustness of UoM price updates by using currency code rather than symbol #16217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
changed the title
kaikreuzer
pushed a commit
that referenced
this pull request
Jan 6, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
|
Cherry-picked to |
kaikreuzer
added
the
patch
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the work-around provided in #16085 after the root cause has been fixed in openhab/openhab-core#4016.
Updating using currency code rather than currency symbol should be more robust since currency code is guaranteed to be unique. Therefore I'd propose to also cherry-pick this fix into 4.1.x along with openhab/openhab-core#4016 which was already cherry-picked.